chore: ensure that pnpm also enforces minimumReleaseAge#40476
Merged
jamietanna merged 1 commit intomainfrom Apr 23, 2026
Merged
chore: ensure that pnpm also enforces minimumReleaseAge#40476jamietanna merged 1 commit intomainfrom
pnpm also enforces minimumReleaseAge#40476jamietanna merged 1 commit intomainfrom
Conversation
viceice
previously approved these changes
Jan 16, 2026
Contributor
Author
|
OK, E2Es are failing becasue: |
Contributor
Author
|
@viceice thoughts on what we should do here? |
Contributor
Author
|
The trouble is that the E2Es don't seem to work with it: |
Member
maybe we need to copy the e2e test to a tmp folder so we're out of the repo workspace? |
jamietanna
force-pushed
the
chore/pnpm-mra
branch
from
0ce5e32 to
21e6f09
Compare
jamietanna
changed the title
pnpm also enforces minimumReleaseAgepnpm also enforces minimumReleaseAge
Contributor
Author
|
Weirdly this works locally 🤔 |
jamietanna
force-pushed
the
chore/pnpm-mra
branch
from
21e6f09 to
be29f28
Compare
Contributor
Author
|
Could be worth waiting for pnpm/pnpm#11224 |
jamietanna
force-pushed
the
chore/pnpm-mra
branch
from
5e89632 to
a3be5cb
Compare
On top of our Renovate configuration[0] not allowing Renovate to prepare updates until npm packages have been available for 7 days, we can provide "defence in depth" by also wiring in pnpm's configuration. This takes the rules from [0] and applies them to explicitly allowlist our packages, as well as set the limit to 7 days. To make sure our E2E tests still operate, we can - in a slightly hacky manner - disable `minimumReleaseAge` by deleting the `pnpm-workspace.yaml`, as it doesn't seem to be possible to `--ignore-workspace` while using `minimumReleaseAge`, as it still requires the `minimumReleaseAge` to pass. [0]: https://github.com/renovatebot/.github/blob/095f454e8b1141edb1045dd389bee4c59c51613e/default.json
jamietanna
force-pushed
the
chore/pnpm-mra
branch
from
a3be5cb to
59a27b3
Compare
viceice
approved these changes
Apr 23, 2026
Contributor
|
🎉 This PR is included in version 43.140.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
On top of our Renovate configuration0 not allowing Renovate to prepare
updates until npm packages have been available for 7 days, we can
provide "defence in depth" by also wiring in pnpm's configuration.
This takes the rules from 0 and applies them to explicitly allowlist
our packages, as well as set the limit to 7 days.
Context
Please select one of the below:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: