You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When self-hosting Renovate using the binarySource=docker mode, it was possible for a malicious dependency name to introduce shell metacharacters and/or introduce remote code execution as the Renovate user.
This depends on a precondition of a dependency which has a malicious package name which would not be a valid Go module name, so the go toolchain would be rejecting it, and Go module proxies would also reject it.
It is most likely that this is therefore an "insider attack", because it requires someone committing code to their default branch - to get Renovate to execute the update - but may also require a malicious Go module proxy.
Because this is not a valid Go module name, it is unlikely this attack could be leveraged.
Renovate's next major release (45, no release date currently planned) will remove the docker CLI from our Docker images, and in Renovate 46 (no release date currently planned), we intend to remove binarySource=docker altogether.
The product constructs all or part of an OS command using externally-influenced input from an upstream component, but it does not neutralize or incorrectly neutralizes special elements that could modify the intended OS command when it is sent to a downstream component.
Learn more on MITRE.
When updating a Go module to a new major version (above v1), the module import path changes, such as:
As well as the dependency update itself, users need to update their source code references to this module, otherwise their code will fail to compile.
Renovate supports automagically updating these using
postUpdateOptions=['gomodUpdateImportPaths', ...], which calls an external command,mod.When self-hosting Renovate using the
binarySource=dockermode, it was possible for a malicious dependency name to introduce shell metacharacters and/or introduce remote code execution as the Renovate user.Impact
binarySource=dockerpostUpdateOptions=['gomodUpdateImportPaths', ...]Note
This depends on a precondition of a dependency which has a malicious package name which would not be a valid Go module name, so the
gotoolchain would be rejecting it, and Go module proxies would also reject it.It is most likely that this is therefore an "insider attack", because it requires someone committing code to their default branch - to get Renovate to execute the update - but may also require a malicious Go module proxy.
Because this is not a valid Go module name, it is unlikely this attack could be leveraged.
Patches
This is patched in Renovate 44.14.7.
Workarounds
Due to the unlikeliness of this attack vector, we recommend patching your Renovate version.
Notes
A reminder that
binarySource=dockeris deprecated.Renovate's next major release (45, no release date currently planned) will remove the
dockerCLI from our Docker images, and in Renovate 46 (no release date currently planned), we intend to removebinarySource=dockeraltogether.If you are using this mode, and cannot migrate to
binarySource=install, please provide feedback in this Discussion.