This repository was archived by the owner on May 18, 2026. It is now read-only.
Fix embedded GLB base color textures - #4
Open
Mr-HDK wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves embedded GLB base color textures when Model3DRenderer replaces loaded GLTF materials with the app's custom shader materials.
Why
GLB files with embedded base color textures loaded successfully, but the texture disappeared after the renderer swapped the original GLTF material for a morph-capable shader material.
Closes #3
How
The renderer now stores each mesh's embedded base color texture before replacing the original material, then passes it into the standard/toon shader as a diffuse sampler. The shader uses the embedded texture color and alpha when present, while keeping existing material controls and deformation effects working.
Test plan
npm run check— 0 errorsnpm run build— succeeds