Standardize "hot" operation timeout#1268
Open
brandur wants to merge 1 commit into
Open
Conversation
This one's a simpler alternative to #1263. All we do is take the existing timeout added in #1255 and standardize it with the timeout we use for job completion, putting a comment on the two saying we should revisit. I decided to leave it as 10 seconds after all (instead of changing it to 30 seconds like I had in #1263) after seeing that job completion already uses 10 seconds. This may still not be long enough for a jobs table in serious trouble due to dead tuples, but if it's not, job completion is already going to be in trouble so it's likely things have degenerated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one's a simpler alternative to #1263. All we do is take the
existing timeout added in #1255 and standardize it with the timeout we
use for job completion, putting a comment on the two saying we should
revisit.
I decided to leave it as 10 seconds after all (instead of changing it to
30 seconds like I had in #1263) after seeing that job completion already
uses 10 seconds. This may still not be long enough for a jobs table in
serious trouble due to dead tuples, but if it's not, job completion is
already going to be in trouble so it's likely things have degenerated.