Fix direction bug in PhysicsUpdateSystem#23
Open
jemc wants to merge 1 commit intorjewson:masterfrom
Open
Conversation
In the prior version of `PhysicsUpdateSystem` logic, if the `PhysicsBody.body.velocity.x` velocity is zero, the `Position.direction.x` will always be updated to point to the negative direction. This was causing the following problematic behavior: - an entity that "walks" rightward and is stopped by a "wall" will switch to facing left when it comes to a stop - an entity that "walks" leftward and is stopped by a "wall" will continue facing left when it comes to a stop After this commit, the behavior is fixed and made consistent by ensuring that when the X velocity is zero we do not update the X direction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the prior version of
PhysicsUpdateSystemlogic, if thePhysicsBody.body.velocity.xvelocity is zero, the
Position.direction.xwill always be updated to point to the negative direction.This was causing the following problematic behavior:
will switch to facing left when it comes to a stop
will continue facing left when it comes to a stop
After this commit, the behavior is fixed and made consistent by ensuring that
when the X velocity is zero we do not update the X direction.