Nemo task5 6 hooks and progress reporting#9
Open
yayajjiang wants to merge 3 commits intorlops:nemofrom
Open
Conversation
… reporting Task 5 (F11-flag, F5-hooks): - Add RLixHooks Protocol with 7-method interface (before/after_generation, before/after_training, before_weight_sync, begin/end_progress_batch) - Add NoOpRLixHooks default implementation for standalone NeMo RL runs - Add NemoRLRLixHooks with GPU hook placeholders (Task 7 TODOs) and Task 3 NCCL placeholder in before_weight_sync - Add grpo.py stub with DO_TIME_SHARING flag and 5 hook insertion points in the correct per-step order Task 6 (F9): - Implement begin_progress_batch / end_progress_batch state machine - 2% bucket granularity (50 buckets), deduplicated fire-and-forget emit - _emit_progress() isolated as overridable method for testability - _emit_progress body is TODO pending Task 7 scheduler actor wiring Tests: 30 unit tests, all passing, no GPU/Ray/vLLM required Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tep_target_estimate bootstrap - grpo.py: begin_progress_batch now called before before_generation each step - TASK5_6_HOOKS.md: add chicken-and-egg problem explanation and two-mechanism solution - test: add test_begin_progress_batch_called_before_before_generation (31 tests total) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.