Skip to content

chore(tests): migrate from goridge rpc to connectrpc#209

Merged
rustatian merged 3 commits into
masterfrom
chore/connectrpc-migration
May 25, 2026
Merged

chore(tests): migrate from goridge rpc to connectrpc#209
rustatian merged 3 commits into
masterfrom
chore/connectrpc-migration

Conversation

@rustatian
Copy link
Copy Markdown
Member

Summary

  • Migrate tests/storage_plugin_test.go from net/rpc + goridge/v4/pkg/rpc codec to the generated kvV2connect client (mirrors the memcached and jobs plugin references)
  • Bump goridge/v4 beta.1 → beta.2 transitively (no longer a direct dep; new wire is Connect/HTTP-2 served by rpc/v6 beta.4 on the same TCP socket)
  • Bump api-go/v6 beta.4 → beta.12 (brings in kvV2connect)
  • Add connectrpc.com/connect v1.20.0 + golang.org/x/net for h2c transport
  • Modernize 4× WaitGroup goroutine spawn to wg.Go(...) (Go 1.25+)

Test plan

  • go build ./... in both module roots
  • go vet ./... in both module roots
  • gofmt -l . clean
  • golangci-lint clean (pre-commit hook)
  • CI: go test -race -count=1 ./... against live redis (TLS + plain)

Replace net/rpc + goridge/v4/pkg/rpc codec with the generated
kvV2connect client, matching the memcached/jobs reference. The rpc
plugin now serves Connect/HTTP-2 endpoints; clients dial over h2c
on the same TCP socket.

- bump goridge/v4 beta.1 → beta.2 (transitive only; no direct dep)
- bump api-go/v6 beta.4 → beta.12 (introduces kvV2connect)
- bump rpc/v6 beta.3 → beta.4 (connectrpc-serving counterpart)
- add connectrpc.com/connect v1.20.0 + golang.org/x/net for http2
- modernize 4× WaitGroup spawn to wg.Go (Go 1.25+)
Copilot AI review requested due to automatic review settings May 25, 2026 08:05
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 25, 2026

Warning

Review limit reached

@rustatian, we couldn't start this review because you've used your available PR reviews for now.

Your plan includes 1 review of capacity. Refill in 53 minutes and 22 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0d93d7b5-4dde-4ddb-add2-0583599ebfd3

📥 Commits

Reviewing files that changed from the base of the PR and between 4458a15 and 2c97248.

⛔ Files ignored due to path filters (2)
  • go.sum is excluded by !**/*.sum
  • tests/go.sum is excluded by !**/*.sum
📒 Files selected for processing (4)
  • .github/workflows/linux.yml
  • go.mod
  • tests/go.mod
  • tests/storage_plugin_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/connectrpc-migration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the tests module’s KV integration tests to use the generated Connect RPC client instead of the legacy net/rpc + Goridge codec, aligning the tests with the newer Connect/HTTP-2 RPC surface.

Changes:

  • Migrated tests/storage_plugin_test.go from net/rpc (Goridge codec) to kvV2connect.KvServiceClient calls using connect.NewRequest(...).
  • Updated test-module dependencies to api-go/v6 v6.0.0-beta.12 (for kvV2connect), added connectrpc.com/connect and golang.org/x/net/http2 for h2c transport, and bumped rpc/v6 to v6.0.0-beta.4.
  • Modernized goroutine spawning in tests to wg.Go(...) and updated module/toolchain metadata + sums accordingly.

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/storage_plugin_test.go Switches KV RPC test calls to Connect client over HTTP/2 (h2c) and modernizes WaitGroup goroutine spawning.
tests/go.mod Adds Connect + x/net deps, bumps RoadRunner API/RPC versions, and updates toolchain patch version.
tests/go.sum Updates sums to reflect the new Connect + HTTP/2 dependency graph and RoadRunner version bumps.
go.mod Bumps golang.org/x/sys to v0.45.0 in the main module.
go.sum Adds checksums for the updated golang.org/x/sys v0.45.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rustatian rustatian self-assigned this May 25, 2026
@rustatian rustatian merged commit 96c1275 into master May 25, 2026
7 checks passed
@rustatian rustatian deleted the chore/connectrpc-migration branch May 25, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants