chore(tests): migrate from goridge rpc to connectrpc#209
Conversation
Replace net/rpc + goridge/v4/pkg/rpc codec with the generated kvV2connect client, matching the memcached/jobs reference. The rpc plugin now serves Connect/HTTP-2 endpoints; clients dial over h2c on the same TCP socket. - bump goridge/v4 beta.1 → beta.2 (transitive only; no direct dep) - bump api-go/v6 beta.4 → beta.12 (introduces kvV2connect) - bump rpc/v6 beta.3 → beta.4 (connectrpc-serving counterpart) - add connectrpc.com/connect v1.20.0 + golang.org/x/net for http2 - modernize 4× WaitGroup spawn to wg.Go (Go 1.25+)
|
Warning Review limit reached
Your plan includes 1 review of capacity. Refill in 53 minutes and 22 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the tests module’s KV integration tests to use the generated Connect RPC client instead of the legacy net/rpc + Goridge codec, aligning the tests with the newer Connect/HTTP-2 RPC surface.
Changes:
- Migrated
tests/storage_plugin_test.gofromnet/rpc(Goridge codec) tokvV2connect.KvServiceClientcalls usingconnect.NewRequest(...). - Updated test-module dependencies to
api-go/v6 v6.0.0-beta.12(forkvV2connect), addedconnectrpc.com/connectandgolang.org/x/net/http2for h2c transport, and bumpedrpc/v6tov6.0.0-beta.4. - Modernized goroutine spawning in tests to
wg.Go(...)and updated module/toolchain metadata + sums accordingly.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/storage_plugin_test.go | Switches KV RPC test calls to Connect client over HTTP/2 (h2c) and modernizes WaitGroup goroutine spawning. |
| tests/go.mod | Adds Connect + x/net deps, bumps RoadRunner API/RPC versions, and updates toolchain patch version. |
| tests/go.sum | Updates sums to reflect the new Connect + HTTP/2 dependency graph and RoadRunner version bumps. |
| go.mod | Bumps golang.org/x/sys to v0.45.0 in the main module. |
| go.sum | Adds checksums for the updated golang.org/x/sys v0.45.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
tests/storage_plugin_test.gofromnet/rpc + goridge/v4/pkg/rpccodec to the generatedkvV2connectclient (mirrors the memcached and jobs plugin references)goridge/v4beta.1 → beta.2 transitively (no longer a direct dep; new wire is Connect/HTTP-2 served byrpc/v6 beta.4on the same TCP socket)api-go/v6beta.4 → beta.12 (brings inkvV2connect)connectrpc.com/connect v1.20.0+golang.org/x/netfor h2c transportwg.Go(...)(Go 1.25+)Test plan
go build ./...in both module rootsgo vet ./...in both module rootsgofmt -l .cleango test -race -count=1 ./...against live redis (TLS + plain)