Feature/add secret type#1985
Draft
yuriverweij wants to merge 10 commits into
Draft
Conversation
… for backward compatibility
… into feature/add-secret-type
…e of secret, but <secret>
…put Password keyword
…r compatibility with older Robot Framework versions
There was a problem hiding this comment.
Pull request overview
Adds Robot Framework 7.4 Secret type compatibility to SeleniumLibrary text-entry keywords so secrets can be passed without exposing values in Robot Framework logs, while maintaining compatibility with older RF versions.
Changes:
- Added
Secretimport with a fallback stand-in class for Robot Framework < 7.4. - Updated
Input TextandInput Passwordto acceptstr | Secret, extracting.valuewhen needed. - Added/updated acceptance test coverage and test-runner exclusion for pre-7.4 environments.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/SeleniumLibrary/utils/types.py |
Adds Secret import with fallback stand-in for RF < 7.4. |
src/SeleniumLibrary/keywords/formelement.py |
Accepts Secret in Input Text/Input Password and unwraps before send_keys; updates keyword docs. |
atest/run.py |
Excludes require-rf-7.4 tagged tests when Robot Framework < 7.4. |
atest/acceptance/keywords/textfields.robot |
Adds acceptance tests for Secret support and log-safety expectations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…, and clarity in documentation
Comment on lines
+226
to
+227
| if tuple(int(x) for x in robot_version.split(".")[:2]) < (7, 4): | ||
| options.extend(["--exclude", "require-rf-7.4"]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the
Secrettype (introduced in Robot Framework 7.4) to theInput TextandInput Passwordkeywords, ensuring sensitive values can be handled securely and without accidental logging. Keeping in mind compatibility problems with older Robot Framework versions.Secret type support and compatibility:
Input TextandInput Passwordkeywords informelement.pyto accept bothstrandSecrettypes, extracting the value fromSecretobjects as needed. This ensures that secret values are not logged and are handled securely.Secrettype inutils/types.py, allowing the code to work with Robot Framework versions both before and after 7.4 by providing a minimal stand-in class if necessary.Acceptance tests and helpers:
textfields.robotto verify thatInput TextandInput Passwordaccept theSecrettype, that plain strings are still accepted for backwards compatibility, and that secret values are not logged.require-rf-7.4to skip specific Secret tests if it is not present.