rtknavi_qt: initialize the refpos#865
Closed
ourairquality wants to merge 1 commit into
Closed
Conversation
Otherwise uninitialized values can be passed through.
Author
|
Actually the 'type' being passed to getPosition() can be out of range for what it expects 0 to 2, see -1 and 6, and the real issue might be elsewhere so let me explore this further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These might have been sources of garbage causing issues initialising in a prior patch that used the base position to initialise early, shall keep exploring that but separately.
Otherwise uninitialized values can be passed through.