refactor: move reflinks into env-configurable DEFAULT_REFLINKS#2
Open
rtunazzz wants to merge 1 commit into
Open
refactor: move reflinks into env-configurable DEFAULT_REFLINKS#2rtunazzz wants to merge 1 commit into
rtunazzz wants to merge 1 commit into
Conversation
Consolidate every hardcoded referral slug into a single DEFAULT_REFLINKS
constant at the top of static/redirect-data.js and parameterize all
reflink-bearing buildUrl closures on a new `ref` argument. The worker
builds the reflinks config at request time from env vars (REF for the
default slug, REF_<PLATFORM> for per-platform overrides, with underscores
mapped to hyphens), falling back to DEFAULT_REFLINKS when nothing is set
so existing deployments are byte-identical without any env var setup.
Since the service worker can't read Cloudflare env, worker.js intercepts
/static/redirect-data.js and appends `self.REFLINKS = {...}` (with
Cache-Control: no-store so env changes propagate without a redeploy);
sw.js reads self.REFLINKS and passes it through to buildRedirectUrl.
Forkers can now customize their reflinks entirely from the Pages
dashboard — no code changes required.
0d8a25d to
8a33933
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate every hardcoded referral slug into a single DEFAULT_REFLINKS
constant at the top of static/redirect-data.js and parameterize all
reflink-bearing buildUrl closures on a new
refargument. The workerbuilds the reflinks config at request time from env vars (REF for the
default slug, REF_ for per-platform overrides, with underscores
mapped to hyphens), falling back to DEFAULT_REFLINKS when nothing is set
so existing deployments are byte-identical without any env var setup.
Since the service worker can't read Cloudflare env, worker.js intercepts
/static/redirect-data.js and appends
self.REFLINKS = {...}(withCache-Control: no-store so env changes propagate without a redeploy);
sw.js reads self.REFLINKS and passes it through to buildRedirectUrl.
Forkers can now customize their reflinks entirely from the Pages
dashboard — no code changes required.