fix(webhook): close response body on every retry attempt - #635
Closed
AruneshDwivedi wants to merge 2 commits into
Closed
fix(webhook): close response body on every retry attempt#635AruneshDwivedi wants to merge 2 commits into
AruneshDwivedi wants to merge 2 commits into
Conversation
Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
runabol
reviewed
Jul 21, 2026
| // Close the response body on every attempt so retries don't leak | ||
| // the previous attempt's body (a deferred Close would only run | ||
| // after the entire retry loop finished). | ||
| defer fns.CloseIgnore(resp.Body) |
Owner
There was a problem hiding this comment.
Great find. How do you feel about just removing the defer ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing: the fix is complete and the package-level tests pass locally (nil-guard against panicking on ingress rules with host but no HTTP block). The upstream CI run is gated on maintainer approval for fork PRs, which is outside the author's control. Raised again if/when the maintainer enables workflow runs for forks.