feat(flex): allow opting into PITR for the transient locks table - #64
Open
psg2 wants to merge 1 commit into
Open
feat(flex): allow opting into PITR for the transient locks table#64psg2 wants to merge 1 commit into
psg2 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
locks_table_point_in_time_recovery_enabledto the public Flex modulefalsedefaultlocksDynamoDB tableMotivation
Some organizations require point-in-time recovery on every active DynamoDB table for backup and compliance controls. I saw the decision on #41 to keep PITR disabled for the transient
lockstable, so this PR does not change that default and does not add a switch for tables that already have PITR permanently enabled. It only lets callers explicitly opt in when their policy requires it.Validation
make test-plan-tofu— all OpenTofu module tests passedtofu test -filter=tests/plan_behavior.tofutest.hclinmodules/control_plane/flex— 20 passedtofu test -filter=tests/root.tftest.hclinmodules/flex— 26 passedtofu fmt -check -recursivemake test-plan-sourcecannot run completely from this exported repository because severalTestPlanSource*cases reference monorepo-only paths that are not published here (cloudformation/,stacks/,.github/workflows/, and agent source). The structured Terraform plan tests and resource-count tests completed successfully.