Use DropCtxt::new_block and new_block_with_statements systematically.#156586
Open
cjgillot wants to merge 3 commits into
Open
Use DropCtxt::new_block and new_block_with_statements systematically.#156586cjgillot wants to merge 3 commits into
cjgillot wants to merge 3 commits into
Conversation
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
oli-obk
approved these changes
May 15, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 15, 2026
…i-obk Use DropCtxt::new_block and new_block_with_statements systematically. Misc cleanups I found while staring at that code.
rust-bors Bot
pushed a commit
that referenced
this pull request
May 15, 2026
…uwer Rollup of 6 pull requests Successful merges: - #155360 (map_try_insert changes) - #156493 (actually run the temp_dir doctest) - #156556 (Require UTF-8 in `Utf8Pattern::StringPattern`) - #156565 (delegation: emit error when self type is not specified and accessed) - #156577 (Test EII UI tests with prefer-dynamic) - #156586 (Use DropCtxt::new_block and new_block_with_statements systematically.)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 15, 2026
…i-obk Use DropCtxt::new_block and new_block_with_statements systematically. Misc cleanups I found while staring at that code.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 15, 2026
…i-obk Use DropCtxt::new_block and new_block_with_statements systematically. Misc cleanups I found while staring at that code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc cleanups I found while staring at that code.