Skip to content

Correctly handle associated items in rustdoc macro expansion#156587

Open
GuillaumeGomez wants to merge 2 commits into
rust-lang:mainfrom
GuillaumeGomez:assoc-items-macro-expansion
Open

Correctly handle associated items in rustdoc macro expansion#156587
GuillaumeGomez wants to merge 2 commits into
rust-lang:mainfrom
GuillaumeGomez:assoc-items-macro-expansion

Conversation

@GuillaumeGomez
Copy link
Copy Markdown
Member

@GuillaumeGomez GuillaumeGomez commented May 14, 2026

Fixes #156075.

The bug was simply that it didn't cover associated items.

r? @Urgau

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels May 14, 2026
@GuillaumeGomez
Copy link
Copy Markdown
Member Author

Also ping @camelid since you reported the issue to me. :p

Copy link
Copy Markdown
Member

@Urgau Urgau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

View changes since this review

@Urgau
Copy link
Copy Markdown
Member

Urgau commented May 15, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 15, 2026

📌 Commit 899be9f has been approved by Urgau

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 15, 2026
…xpansion, r=Urgau

Correctly handle associated items in rustdoc macro expansion

Fixes rust-lang#156075.

The bug was simply that it didn't cover associated items.

r? @Urgau
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 15, 2026
…xpansion, r=Urgau

Correctly handle associated items in rustdoc macro expansion

Fixes rust-lang#156075.

The bug was simply that it didn't cover associated items.

r? @Urgau
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 15, 2026
…xpansion, r=Urgau

Correctly handle associated items in rustdoc macro expansion

Fixes rust-lang#156075.

The bug was simply that it didn't cover associated items.

r? @Urgau
rust-bors Bot pushed a commit that referenced this pull request May 15, 2026
…uwer

Rollup of 8 pull requests

Successful merges:

 - #156493 (actually run the temp_dir doctest)
 - #156452 (Implement pinned drop sugar)
 - #156600 (Make const param default test reproduce original ICE)
 - #156556 (Require UTF-8 in `Utf8Pattern::StringPattern`)
 - #156565 (delegation: emit error when self type is not specified and accessed)
 - #156577 (Test EII UI tests with prefer-dynamic)
 - #156586 (Use DropCtxt::new_block and new_block_with_statements systematically.)
 - #156587 (Correctly handle associated items in rustdoc macro expansion)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect macro expansion in rustdoc source view

3 participants