Skip to content

rustdoc: test ignoring rustc lints in CLI#156618

Open
notriddle wants to merge 1 commit into
rust-lang:mainfrom
notriddle:rustdoc-lint-ignore-cli
Open

rustdoc: test ignoring rustc lints in CLI#156618
notriddle wants to merge 1 commit into
rust-lang:mainfrom
notriddle:rustdoc-lint-ignore-cli

Conversation

@notriddle
Copy link
Copy Markdown
Contributor

This works, but I couldn't find any tests for it.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels May 15, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 15, 2026

r? @lolbinarycat

rustbot has assigned @lolbinarycat.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: rustdoc
  • rustdoc expanded to 9 candidates
  • Random selection from GuillaumeGomez, fmease, lolbinarycat

@lolbinarycat
Copy link
Copy Markdown
Contributor

the commit/PR title seems backwards, shouldn't it be "rustdoc: test denying rustc lints via CLI"?

in which case, we're not actually testing that, since the entire point of the modified test is that the lint doesn't pass.

if you actually wanted to make sure lint flags for rustc lints work properly, you'd have to find an allow lint for a check-pass test, or a deny lint for a check-fail test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants