Fix debug mode for audio filters example#226
Merged
Conversation
Meziu
force-pushed
the
fix/debug-audio-example
branch
from
9f0d636 to
47f59ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #221
The crash was caused by a stack overflow since the allocation was made with an incredibly long constant byte-buffer on the stack.
Instead, this fix uses
Vecallocation and dynamic data insertion for a slimmer approach (that is also a bit more rusty) at the cost of needing a separate Buffer type with custom trait implementations.Either way, filling the buffer is so slow in debug mode that I still needed to add a warning in case someone runs it in debug.