Skip to content

fix: redact STS credential field aliases#181

Merged
GatewayJ merged 1 commit into
rustfs:mainfrom
GatewayJ:fix/sts-credential-redaction
Jul 11, 2026
Merged

fix: redact STS credential field aliases#181
GatewayJ merged 1 commit into
rustfs:mainfrom
GatewayJ:fix/sts-credential-redaction

Conversation

@GatewayJ

Copy link
Copy Markdown
Member

Type of Change

  • New Feature
  • Bug Fix
  • Documentation
  • Performance Improvement
  • Test/CI
  • Refactor
  • Other:

Related Issues

Follow-up to PR review feedback on #180: #180 (comment)

Summary of Changes

  • Add STS credential field aliases (AccessKeyId, SecretAccessKey) to upstream error redaction.
  • Cover both key/value summaries and XML tag redaction before RustFS upstream response bodies are surfaced in operator errors.
  • Extend sanitizer and RustFS client error summary tests for the STS credential field names.

Checklist

  • I have read and followed the CONTRIBUTING.md guidelines
  • Passed make pre-commit (fmt-check + clippy + test + console-lint + console-fmt-check)
  • Added/updated necessary tests
  • Documentation updated (if needed; N/A)
  • CHANGELOG.md updated under [Unreleased] (if user-visible change; N/A)
  • CI/CD passed (if applicable)

Impact

  • Breaking change (CRD/API compatibility)
  • Requires doc/config/deployment update
  • Other impact: prevents STS credential values from appearing in upstream error details.

Verification

cargo test redacts_sts_credential_field_names
cargo test unexpected_status_redacts_sensitive_upstream_error_summary
git diff --check
make pre-commit

Additional Notes

This keeps the existing redaction approach intact and only extends the sensitive-key aliases used by the existing match paths.


Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.

@GatewayJ GatewayJ marked this pull request as ready for review July 11, 2026 15:44
@GatewayJ GatewayJ added this pull request to the merge queue Jul 11, 2026
Merged via the queue into rustfs:main with commit e3cac0e Jul 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant