Add SpessaSynth - #608
Conversation
|
@spessasus is attempting to deploy a commit to the Ryohei Kameyama's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
About the list of Fixes at the end of your message... Just to make sure you are aware, Signal already lets you change to a custom soundfont. Can you explain more why you feel this pull request will fix issues 458 and 514?
|
|
Hi! Issue 514 is on the list because it's an issue that should've been closed long ago (because there's no data there), but Ryohey doesn't seem to close invalid issues. Since it's related to soundfonts, I included it. Ryohey can edit my comment to remove it if he thinks otherwise. |
|
wow it looks amazing! |
No problem! If you have any questions about the way I implemented it, feel free to ask. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
When I tired the preview, I get a dialog box that says:
And in the Developer Tools Console page I see various errors such as:
|
|
It works for me, but this is presumably due to the libs still not supporting your outdated chrome. I've updated them now, it should work. But please clone and build manually, as vercel might not have updated them. |
|
@spessasus Just testing it a bit. It seems to be working perfectly! I'm enjoying touhou projects midis on signal :) |
I'm glad the patch is working so far! Regarding your question: In the ideal world, we'd maintain a Looking forward to the merge! |
|
I have reverted the interval to 50ms and updated spessasynth libraries to latest (which fixed some small issues). I think it's ready to merge now. |
|
Any updates on this? Can it be merged now? |
ryohey
left a comment
There was a problem hiding this comment.
It's working perfectly! Thank you @spessasus!.
Due to family circumstances, I haven't had much time to check Discord. @robertnhart If there are any issues, please let me know by creating an issue on GitHub. I know that many people, including students, are using this app, so I'd like to know right away if there are any problems on their devices.
This pull request replaces the
waveletaudio engine with SpessaSynth!The features added include:
gm.dlscan be used directly!)Tested on Brave (Chrome) and Floorp (Firefox)
Both export methods (WAV and MP3) work.
Notes on the implementation:
.gitignore, feel free to removeREADME.mdof the player packagepackage-lock.json, i rannpm install, and only installed spessasynth in theplayerpackageMIDIBuilder(translatesPlayerEvents to it). This allows the worklet for frame-perfect timing when renderingFixes #458
Fixes #514
Fixes #459
Fixes #428
Fixes #372
CC: @ryohey @robertnhart