Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dependency-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ jobs:
show-progress: false

- name: 'Dependency Review'
uses: actions/dependency-review-action@38ecb5b593bf0eb19e335c03f97670f792489a8b # v4.7.0
uses: actions/dependency-review-action@da24556b548a50705dd671f47852072ea4c105d9 # v4.7.1
20 changes: 16 additions & 4 deletions lib/modules/datasource/docker/index.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1505,7 +1505,8 @@ describe('modules/datasource/docker/index', () => {

it('jfrog artifactory - retry tags for official images by injecting `/library` after repository and before image', async () => {
const tags1 = [...range(1, 10000)].map((i) => `${i}.0.0`);
const tags2 = [...range(10000, 10050)].map((i) => `${i}.0.0`);
const tags2 = [...range(10000, 20000)].map((i) => `${i}.0.0`);
const tags3 = [...range(20000, 20050)].map((i) => `${i}.0.0`);
httpMock
.scope('https://org.jfrog.io/v2')
.get('/virtual-mirror/node/tags/list?n=10000')
Expand All @@ -1530,17 +1531,28 @@ describe('modules/datasource/docker/index', () => {
.reply(
200,
{ tags: tags2 },
{ 'x-jfrog-version': 'Artifactory/7.42.2 74202900' },
{
'x-jfrog-version': 'Artifactory/7.42.2 74202900',
link: '</library/node/tags/list?n=10000&last=20000>; rel="next", ',
},
)
.get('/virtual-mirror/library/node/tags/list?n=10000&last=20000')
.reply(
200,
{ tags: tags3 },
{
'x-jfrog-version': 'Artifactory/7.42.2 74202900',
},
)
.get('/')
.reply(200, '', {})
.get('/virtual-mirror/node/manifests/10050.0.0')
.get('/virtual-mirror/node/manifests/20050.0.0')
.reply(200, '', {});
const res = await getPkgReleases({
datasource: DockerDatasource.id,
packageName: 'org.jfrog.io/virtual-mirror/node',
});
expect(res?.releases).toHaveLength(10050);
expect(res?.releases).toHaveLength(20050);
});

it('uses lower tag limit for ECR deps', async () => {
Expand Down
20 changes: 14 additions & 6 deletions lib/modules/datasource/docker/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -696,13 +696,21 @@ export class DockerDatasource extends Datasource {
tags = tags.concat(res.body.tags);
const linkHeader = parseLinkHeader(res.headers.link);
if (isArtifactoryServer(res)) {
// Artifactory incorrectly returns a next link without the virtual repository name
// this is due to a bug in Artifactory https://jfrog.atlassian.net/browse/RTFACT-18971
url = linkHeader?.next?.last
? `${url}&last=${linkHeader.next.last}`
: null;
// Artifactory bug: next link comes back without virtual-repo prefix (RTFACT-18971)
if (linkHeader?.next?.last) {
// parse the current URL, strip any old "last" param, then set the new one
const parsed: URL = new URL(url);
parsed.searchParams.delete('last');
parsed.searchParams.set('last', linkHeader.next.last);
url = parsed.href;
} else {
url = null;
}
} else if (linkHeader?.next?.url) {
// for the normal case we can still use URL to resolve relative-next
url = new URL(linkHeader.next.url, url).href;
} else {
url = linkHeader?.next ? new URL(linkHeader.next.url, url).href : null;
url = null;
}
page += 1;
} while (url && page < pages);
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@
"@types/mdast": "3.0.15",
"@types/moo": "0.5.10",
"@types/ms": "2.1.0",
"@types/node": "22.15.12",
"@types/node": "22.15.13",
"@types/parse-link-header": "2.0.3",
"@types/punycode": "2.1.4",
"@types/semver": "7.7.0",
Expand Down
8 changes: 4 additions & 4 deletions pdm.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading