Skip to content

[pull] main from renovatebot:main #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Jul 17, 2025
Merged

[pull] main from renovatebot:main #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f63f4a
fix(datasource/maven): remove tags (#37021)
rarkins Jul 17, 2025
f3cebb9
fix(deps): update ghcr.io/renovatebot/base-image docker tag to v10.20…
renovate[bot] Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions lib/modules/datasource/clojure/__snapshots__/index.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@ exports[`modules/datasource/clojure/index > falls back to next registry url 1`]
"version": "2.0.0",
},
],
"tags": {
"latest": "2.0.0",
"release": "2.0.0",
},
}
`;

Expand Down Expand Up @@ -105,10 +101,6 @@ exports[`modules/datasource/clojure/index > returns releases from custom reposit
"version": "2.0.0",
},
],
"tags": {
"latest": "2.0.0",
"release": "2.0.0",
},
}
`;

Expand Down Expand Up @@ -146,10 +138,6 @@ exports[`modules/datasource/clojure/index > skips registry with invalid XML 1`]
"version": "2.0.0",
},
],
"tags": {
"latest": "2.0.0",
"release": "2.0.0",
},
}
`;

Expand Down Expand Up @@ -187,9 +175,5 @@ exports[`modules/datasource/clojure/index > skips registry with invalid metadata
"version": "2.0.0",
},
],
"tags": {
"latest": "2.0.0",
"release": "2.0.0",
},
}
`;
24 changes: 0 additions & 24 deletions lib/modules/datasource/maven/__snapshots__/index.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@ exports[`modules/datasource/maven/index > falls back to next registry url 1`] =
"version": "2.0.0",
},
],
"tags": {
"latest": "2.0.0",
"release": "2.0.0",
},
}
`;

Expand Down Expand Up @@ -105,10 +101,6 @@ exports[`modules/datasource/maven/index > removes authentication header after re
"version": "2.0.0",
},
],
"tags": {
"latest": "2.0.0",
"release": "2.0.0",
},
}
`;

Expand Down Expand Up @@ -146,10 +138,6 @@ exports[`modules/datasource/maven/index > returns releases 1`] = `
"version": "2.0.0",
},
],
"tags": {
"latest": "2.0.0",
"release": "2.0.0",
},
}
`;

Expand Down Expand Up @@ -188,10 +176,6 @@ exports[`modules/datasource/maven/index > returns releases from custom repositor
"version": "2.0.0",
},
],
"tags": {
"latest": "2.0.0",
"release": "2.0.0",
},
}
`;

Expand Down Expand Up @@ -229,10 +213,6 @@ exports[`modules/datasource/maven/index > skips registry with invalid XML 1`] =
"version": "2.0.0",
},
],
"tags": {
"latest": "2.0.0",
"release": "2.0.0",
},
}
`;

Expand Down Expand Up @@ -270,9 +250,5 @@ exports[`modules/datasource/maven/index > skips registry with invalid metadata s
"version": "2.0.0",
},
],
"tags": {
"latest": "2.0.0",
"release": "2.0.0",
},
}
`;
16 changes: 0 additions & 16 deletions lib/modules/datasource/maven/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,6 @@ describe('modules/datasource/maven/index', () => {
packageScope: 'org.example',
registryUrl: 'https://repo.maven.apache.org/maven2',
releases: [{ version: '1.0.3-SNAPSHOT' }],
tags: {
latest: '1.0.3-SNAPSHOT',
release: '1.0.3-SNAPSHOT',
},
});
});

Expand Down Expand Up @@ -197,10 +193,6 @@ describe('modules/datasource/maven/index', () => {
packageScope: 'org.example',
registryUrl: 'https://repo.maven.apache.org/maven2',
releases: [{ version: '1.0.3-SNAPSHOT' }],
tags: {
latest: '1.0.3-SNAPSHOT',
release: '1.0.3-SNAPSHOT',
},
});
});

Expand Down Expand Up @@ -479,10 +471,6 @@ describe('modules/datasource/maven/index', () => {
{ version: '1.0.5-SNAPSHOT' },
{ version: '2.0.0' },
],
tags: {
latest: '2.0.0',
release: '2.0.0',
},
isPrivate: true,
});
expect(googleAuth).toHaveBeenCalledTimes(2);
Expand Down Expand Up @@ -528,10 +516,6 @@ describe('modules/datasource/maven/index', () => {
{ version: '1.0.5-SNAPSHOT' },
{ version: '2.0.0' },
],
tags: {
latest: '2.0.0',
release: '2.0.0',
},
isPrivate: true,
});
expect(googleAuth).toHaveBeenCalledTimes(2);
Expand Down
10 changes: 0 additions & 10 deletions lib/modules/datasource/maven/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,6 @@ function extractVersions(metadata: XmlDocument): MetadataResults {
return res;
}
res.versions = elements.map((el) => el.val);
const latest = metadata.descendantWithPath('versioning.latest');
if (latest?.val) {
res.tags ??= {};
res.tags.latest = latest.val;
}
const release = metadata.descendantWithPath('versioning.release');
if (release?.val) {
res.tags ??= {};
res.tags.release = release.val;
}

return res;
}
Expand Down
8 changes: 6 additions & 2 deletions lib/modules/datasource/maven/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,9 @@ For example:

#### latest and release tags

When `latest` or `release` values are present in a package's `maven-metadata.xml`, Renovate will map these to its `tags` concept.
This enables the use of Renovate's `followTag` feature.
Although a package's `maven-metadata.xml` may contain `latest` and `release` tags, we do not map them to `tags.latest` or `tags.release` in Renovate internal data.
The reason for not doing this is that Maven registries don't use these tags as an indicator of stability - `latest` essentially means "the most recent version which was published".

For more information on this, see the analysis done in [Discussion #36927](https://github.com/renovatebot/renovate/discussions/36927).

As a result, neither `followTag` nor `respectLatest` concepts apply to Maven dependencies.
4 changes: 0 additions & 4 deletions lib/modules/datasource/maven/s3.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,6 @@ describe('modules/datasource/maven/s3', () => {
{ version: '1.0.2' },
{ version: '1.0.3' },
],
tags: {
latest: '1.0.2',
release: '1.0.2',
},
isPrivate: true,
});
});
Expand Down
6 changes: 3 additions & 3 deletions tools/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,19 @@ ARG BASE_IMAGE_TYPE=slim
# --------------------------------------
# slim image
# --------------------------------------
FROM ghcr.io/renovatebot/base-image:10.20.1@sha256:0e324299a0c8b94d526094f92a9d54a6ac3f5364fe8a3f66934cd16188b9c916 AS slim-base
FROM ghcr.io/renovatebot/base-image:10.20.2@sha256:a9735b6c085c672278685e34bdf786cb2a840b0ef2477e18a2274bf8fd3ab610 AS slim-base

# --------------------------------------
# full image
# --------------------------------------
FROM ghcr.io/renovatebot/base-image:10.20.1-full@sha256:7f4eb246b5a5538a0fdc99f6b6a5ab7a96d4cbc9342378f11ac699d42659a01e AS full-base
FROM ghcr.io/renovatebot/base-image:10.20.2-full@sha256:a06a26a845673b416e920e178a98ea1cc8cb930a185999396d8bf89ce3e2e8c3 AS full-base

ENV RENOVATE_BINARY_SOURCE=global

# --------------------------------------
# build image
# --------------------------------------
FROM --platform=$BUILDPLATFORM ghcr.io/renovatebot/base-image:10.20.1@sha256:0e324299a0c8b94d526094f92a9d54a6ac3f5364fe8a3f66934cd16188b9c916 AS build
FROM --platform=$BUILDPLATFORM ghcr.io/renovatebot/base-image:10.20.2@sha256:a9735b6c085c672278685e34bdf786cb2a840b0ef2477e18a2274bf8fd3ab610 AS build

# We want a specific node version here
# renovate: datasource=github-releases packageName=containerbase/node-prebuild versioning=node
Expand Down
Loading