Skip to content

fix: use approved Roby's identity v4 across Smart Choice - #289

Merged
safal207 merged 7 commits into
mainfrom
fix/smart-choice-approved-brand-v4
Jul 28, 2026
Merged

fix: use approved Roby's identity v4 across Smart Choice#289
safal207 merged 7 commits into
mainfrom
fix/smart-choice-approved-brand-v4

Conversation

@safal207

@safal207 safal207 commented Jul 28, 2026

Copy link
Copy Markdown
Owner

Why

Post-merge visual inspection found that the Smart Choice client header reconstructed the wordmark with CSS and the owner simulator rendered a text-only ROBY'S label. Both surfaces therefore bypassed the owner-approved SVG-path identity v4 used by Home, Menu, and Discover.

Change

  • load the shared brand-photo-logo.css?v=20260726-approved-v4 contract on both Smart Choice surfaces;
  • add a bounded responsive adapter using the exact approved compact SVG master;
  • replace the simulator text-only wordmark with accessible brand-copy markup backed by that SVG;
  • extend the Smart Choice release verifier to reject missing/shared-v4 identity, text-only simulator branding, and absent narrow-mobile sizing;
  • rebuild generated files and integrity evidence before sealing.

Boundary

No recommendation, catalog, price, cart, analytics, experiment, simulator calculation, or public-order behavior changes.

Summary by CodeRabbit

  • New Features

    • Updated Smart Choice branding with the approved compact SVG identity across the main experience and owner simulator.
    • Added responsive sizing so the brand remains clear and well-proportioned on narrow screens.
    • Preserved accessible brand labeling, including a descriptive home-link label in the simulator.
  • Bug Fixes

    • Replaced reconstructed and text-only wordmarks with the shared approved visual identity.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9d36cae5-d947-466a-9678-2b144382497e

📥 Commits

Reviewing files that changed from the base of the PR and between 6ec510b and 7d6f73c.

📒 Files selected for processing (6)
  • docs/smart-choice-release-v1.md
  • integrity-manifest.json
  • scripts/verify-smart-choice-release.mjs
  • smart-choice/brand-v4.css
  • smart-choice/index.html
  • smart-choice/simulator.html

📝 Walkthrough

Walkthrough

Smart Choice pages now load the approved identity v4 styles, the simulator uses accessible structured brand markup, and the release verifier checks identity revisions, responsive sizing, simulator rendering, CSS budgets, and updated integrity records.

Changes

Smart Choice identity

Layer / File(s) Summary
Brand asset and page integration
smart-choice/brand-v4.css, smart-choice/index.html, smart-choice/simulator.html
Adds responsive compact SVG-path branding, versioned stylesheet links, and structured accessible simulator brand markup.
Approved identity release checks
scripts/verify-smart-choice-release.mjs
Verifies approved identity assets across both pages, checks narrow-mobile sizing, includes the new stylesheet in CSS budgets, and updates the verification output.
Release records and inspection documentation
integrity-manifest.json, docs/smart-choice-release-v1.md
Updates Smart Choice asset hashes and documents the post-merge identity inspection requirement.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant ReleaseVerifier
  participant SmartChoicePages
  participant SharedIdentityCSS
  participant BrandV4CSS
  ReleaseVerifier->>SmartChoicePages: read index.html and simulator.html
  SmartChoicePages->>SharedIdentityCSS: load versioned shared identity stylesheet
  SmartChoicePages->>BrandV4CSS: load versioned identity adapter
  ReleaseVerifier->>BrandV4CSS: verify SVG revision and responsive rules
  ReleaseVerifier-->>ReleaseVerifier: report approved identity v4 verification
Loading

Possibly related issues

Possibly related PRs

Suggested labels: ready-for-review

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/smart-choice-approved-brand-v4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@safal207
safal207 marked this pull request as ready for review July 28, 2026 08:48
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

🚦 Roby’s Lighthouse contract

Mobile

Metric Current Baseline Delta Status
Performance 0.98 1.00 -1.50%
LCP 1803 ms 1746 ms +3.25%
TBT 1 ms 5 ms -75.00%
CLS 0.00 0.00 -0.00%
FCP 1485 ms
Speed Index 1485 ms
Total JS 22 KB 21 KB +5.32%
Hero file 78 KB 78 KB -0.15%
Hero transfer 0 KB
Hero request 0 ms

Hard assertions: ✅ · Regression: ❌
· Public Lighthouse report

Desktop

Metric Current Baseline Delta Status
Performance 1.00 1.00 0.00%
LCP 444 ms 460 ms -3.58%
TBT 0 ms 0 ms 0.00%
CLS 0.00 0.00 0.00%
FCP 363 ms
Speed Index 453 ms
Total JS 22 KB 21 KB +5.32%
Hero file 78 KB 78 KB -0.15%
Hero transfer 0 KB
Hero request 0 ms

Hard assertions: ✅ · Regression: ❌
· Public Lighthouse report

D.1 runs in observability mode. The final gate is enabled only after the reviewed baseline commit.

@safal207
safal207 merged commit 77a9ed4 into main Jul 28, 2026
25 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant