chore: change nsis script to use global cmd.exe @W-19315214@#2365
Merged
Conversation
…into wr/winInstallerCmdExe
shetzel
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
changes the custom nsis used in
sffor checking for installedsfdxCLI to use the global cmd.exe instead of a local, possibly malicious cmd.exe fileAcceptance Criteria
Testing Notes
oh boi - needs a windows machine
needs oclif/oclif#1852
setup:
(I had to delete the JIT section in pjson in CLI for some steps to work locally)
oclif pack:tarballs --xz --parallel --prune-lockfiles --targets win32-x64or whatever windows target you need (just builds one, instead of every, installer)../path/to/oclif/bin/run.js pack:win --prune-lockfiles --targets win32-x64 --defender-exclusion unchecked.nsifile. I believe this file is in the output, and it's intmp/. You canmakensis path/to/.nsiwhich will compile your.nsiinto a.exe, you can then drag that .exe into your testing folderdist/to your directory with a "malicious" cmd.exe program in it and installNotes:
sometimes the
pack:wincommand would fail, but I'd still get the requiredsf.nsifile, which then I'd have to runmakensis path/to/sf.nsiwhich would build the installerChecklist
What issues does this PR fix or reference?
@W-19315214@