sizing: fold the thirteen size parsers into one - #293
Merged
Conversation
Each sizing family now names its CSS property, class prefix, keyword table and suborder offsets as data, so one parser, one to_style and one to_class serve all of them, and the container scale is defined once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each sizing family now names its CSS property, class prefix, keyword table and suborder offsets as data, so one parser, one
to_styleand oneto_classserve all of them; the container scale and its defaults are defined once instead of three times.Emitted CSS is byte-identical for 1071 sizing classes and for the whole-list ordering run, and 61 rejected shapes still parse-fail the same way. The one behaviour change:
size-<n>/<m>fractions outside the old eleven-entry list (size-3/8,size-4/12, ...) parsed but then raisedFailurefromto_style; they now resolve to the percentage every other family already gave them.