lib: name the module a shadowed constructor comes from - #298
Open
samoht wants to merge 2 commits into
Open
Conversation
An `open Css` or `open Css.Selector` was quietly taking over `None`, `Focus`, `Odd` and friends, so a bare constructor could mean either module's. Each such use now names the one it wants.
Warning 45 is off in dune's default set, which is how the shadowed uses in the previous commit went unnoticed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open Cssandopen Css.Selectorwere quietly taking overNone,Focus,Oddand friends, so a bare constructor could mean either module's. Warning 45 is now an error and every such use spells out the module it wants.