feat: stalign with a fit apply pattern. #1195
Open
selmanozleyen wants to merge 150 commits into
Open
Conversation
for more information, see https://pre-commit.ci
…leyen/squidpy into feat/spatial_neighbours
for more information, see https://pre-commit.ci
…leyen/squidpy into feat/spatial_neighbours
…leyen/squidpy into feat/spatial_neighbours
for more information, see https://pre-commit.ci
…leyen/squidpy into feat/spatial_neighbours
for more information, see https://pre-commit.ci
…leyen/squidpy into feat/spatial_neighbours
selmanozleyen
changed the title
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…nozleyen/squidpy into feat/experimental-fit-core
for more information, see https://pre-commit.ci
…nozleyen/squidpy into feat/experimental-fit-core
for more information, see https://pre-commit.ci
timtreis
reviewed
Jun 23, 2026
| import numpy.typing as npt | ||
|
|
||
| from squidpy._utils import NDArrayA | ||
| from squidpy.experimental.methods.registry import ALIGN_LANDMARKS |
Member
There was a problem hiding this comment.
Why are we using a registry here? It's unlikely this will get extended upon much and it introduces complexity
timtreis
reviewed
Jun 23, 2026
| query: np.ndarray, | ||
| *, | ||
| method: str, | ||
| solve_fn: Callable[[np.ndarray, np.ndarray], np.ndarray], |
Member
There was a problem hiding this comment.
Shouldn't it be Callable[np.ndarray, np.ndarray]?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #1162