Skip to content

fix(sidebar): restore info panel padding and darken sidebar background#124

Merged
astyfx merged 2 commits into
mainfrom
fix/sidebar-revamp-p2--continue--20260709-042535
Jul 9, 2026
Merged

fix(sidebar): restore info panel padding and darken sidebar background#124
astyfx merged 2 commits into
mainfrom
fix/sidebar-revamp-p2--continue--20260709-042535

Conversation

@astyfx

@astyfx astyfx commented Jul 9, 2026

Copy link
Copy Markdown
Member

Summary

  • The sidebar reorder work (feat(sidebar): reorder projects/workspaces via long-press drag #121) dropped the outer wrapper's px-3 on the Information panel content, leaving only py-2 and misaligning it with the px-3 panel header title. Restored px-3 py-2.
  • The left project/workspace sidebar had no explicit background class, so it inherited --background and blended with the GNB and chat panel (both bg-card). Applied bg-sidebar to the sidebar root so the existing --sidebar token is actually used.
  • The default light/dark themes and 4 built-in themes (Dark High Contrast, One Dark Pro, Tokyo Night, Solarized Light) had --sidebar set equal to --card, so darkened --sidebar one step below --card in those themes, reusing each theme's existing darker tone (input/surface) to stay within its palette.

Test plan

  • bun run typecheck
  • bun test tests/custom-theme.test.ts tests/app-shell-mode.test.ts
  • Visual check across default + built-in themes: sidebar reads as a distinct, slightly darker layer vs GNB/chat

The section-reorder PR dropped the outer wrapper's px-3, misaligning
the panel content with the header title. Restore px-3 py-2.
@astyfx astyfx enabled auto-merge (squash) July 9, 2026 07:06
The left sidebar rendered without any explicit background class, so it
inherited the page's --background and blended with the GNB and chat
panel (both bg-card). Apply bg-sidebar to the sidebar root so the
existing --sidebar token is actually used.

The default light/dark themes and 4 built-in themes (Dark High
Contrast, One Dark Pro, Tokyo Night, Solarized Light) had --sidebar
set equal to --card, so darken --sidebar one step below --card in
those themes, reusing each theme's existing darker tone (input/
surface) to stay within its palette.
@astyfx astyfx changed the title fix(sidebar): restore information panel horizontal padding fix(sidebar): restore info panel padding and darken sidebar background Jul 9, 2026
@astyfx astyfx merged commit 633acf4 into main Jul 9, 2026
4 checks passed
@astyfx astyfx deleted the fix/sidebar-revamp-p2--continue--20260709-042535 branch July 9, 2026 09:13
@astyfx astyfx mentioned this pull request Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants