Skip to content

Allow override of protobuf_FORCE_FETCH_DEPENDENCIES - #4793

Open
ngoquang2708 wants to merge 1 commit into
shadps4-emu:mainfrom
ngoquang2708:protobuf-override
Open

Allow override of protobuf_FORCE_FETCH_DEPENDENCIES#4793
ngoquang2708 wants to merge 1 commit into
shadps4-emu:mainfrom
ngoquang2708:protobuf-override

Conversation

@ngoquang2708

Copy link
Copy Markdown
Contributor

flatpak-builder disallow internet access in build-time.

This allow us to build protobuf's dependencies (abseil in this case) with clang to avoid linking issue.

Ref: flathub/net.shadps4.shadPS4#77.

`flatpak-builder` disallow internet access in build-time.
@squidbus

squidbus commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

@georgemoralis Is this something we needed to download at build time to begin with, feel like we could've just submodule'd this ourselves.

@georgemoralis

Copy link
Copy Markdown
Collaborator

not sure how that switch works ;/

@ngoquang2708

Copy link
Copy Markdown
Contributor Author

protobuf_FORCE_FETCH_DEPENDENCIES force protobuf to fetch and build abseil by it self.
Currently we hardcoded protobuf_FORCE_FETCH_DEPENDENCIES to ON.
This PR allow us to override that.
@squidbus suggestion is good to me.

@ConnorG512

Copy link
Copy Markdown
Contributor

Nix also dissalows internet access through building. I worked around it also by pulling the abseil source before the build and overwriting the source path when CMake calls its fetch content. If we can use a submodule for it then that step could probably be avoided completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants