Allow override of protobuf_FORCE_FETCH_DEPENDENCIES - #4793
Open
ngoquang2708 wants to merge 1 commit into
Open
Conversation
`flatpak-builder` disallow internet access in build-time.
Collaborator
|
@georgemoralis Is this something we needed to download at build time to begin with, feel like we could've just submodule'd this ourselves. |
Collaborator
|
not sure how that switch works ;/ |
Contributor
Author
|
|
Contributor
|
Nix also dissalows internet access through building. I worked around it also by pulling the abseil source before the build and overwriting the source path when CMake calls its fetch content. If we can use a submodule for it then that step could probably be avoided completely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flatpak-builderdisallow internet access in build-time.This allow us to build
protobuf's dependencies (abseil in this case) withclangto avoid linking issue.Ref: flathub/net.shadps4.shadPS4#77.