Select Directory, No-Download Quit & cURL for Apple Silicon#41
Open
sirj0k3r wants to merge 3 commits intoshijimasoft:mainfrom
Open
Select Directory, No-Download Quit & cURL for Apple Silicon#41sirj0k3r wants to merge 3 commits intoshijimasoft:mainfrom
sirj0k3r wants to merge 3 commits intoshijimasoft:mainfrom
Conversation
* Changed from wget to curl for Apple Silicon
Author
|
@shijimasoft it'd be my honor to have these changes merged into the main branch. Could you consider checking them out? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to change a few behaviors, namely:
curlinstead ofwgetfor Apple Silicon devices.Changes
Directory Argument
The tool now checks for the first argument and checks if it's an existing directory.
If so, the tool will use that directory to scan for and export files.
Otherwise, the tool will use the current directory (
".") as it would normally do.Continue Message
The tool now asks, after a user chooses not to download any external tool, if they want to continue or abort.
cURL for Apple Silicon
The tool now uses
curlinstead ofwgetfor Apple Silicon devices.Motivation
Directory Argument
Preventing users from having to move files to and from the tool's directory is a good quality of life feature.
Continue Message
Continuing without prompting might not be desirable under some situations.
cURL for Apple Silicon
As stated by user @fillito,
wgetis not pre-installed by default on macOS.Using
curlallows for the tool not to force the user to installbrew.