Skip to content

test: add authjs tests and bump dependencies#1088

Open
phoenix-ru wants to merge 4 commits intomainfrom
test/add-authjs-tests
Open

test: add authjs tests and bump dependencies#1088
phoenix-ru wants to merge 4 commits intomainfrom
test/add-authjs-tests

Conversation

@phoenix-ru
Copy link
Copy Markdown
Member

🔗 Linked issue

N/A

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR adds testing to authjs provider using Playwright, similar to what was done for local provider.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 27, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@sidebase/nuxt-auth@1088

commit: acb43f0

"vitest": "^3.2.4",
"vue-tsc": "^2.2.12"
"vitest": "^4.1.2",
"vue-tsc": "^3.2.6"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty big bump to vue-tsc. Are there any other packages that make sense to update too (e.g. jump to typescript 6?)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soooo? 👀

Comment thread src/runtime/composables/authjs/useAuth.ts
Comment thread pnpm-lock.yaml
Copy link
Copy Markdown
Member

@zoey-kaiser zoey-kaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code approved! Can you please adjust the PR title to be more exact about the changes prior to merging 🙏

@phoenix-ru phoenix-ru changed the title test: add authjs tests test: add authjs tests and bump dependencies Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants