Conversation
|
@TheSceneman the changes look good, but we'll need to figure out what the issue with PHP 8.3 is. I would suggest hitting up the product team about this one: |
PHPCS does not suppot the data provider in tests!
| <description>CodeSniffer ruleset for SilverStripe coding conventions.</description> | ||
|
|
||
| <file>src</file> | ||
| <file>tests</file> |
There was a problem hiding this comment.
This is not the best option, but PHPCS is failing to understand #[DataProvider('readingModes')].
Unable to find a solution for it. This can be rewritten without the PHP Attributes or exclude tests from PHPCS until it supports it!
There was a problem hiding this comment.
I'd be fine with tests being excluded from PHPCS
There was a problem hiding this comment.
Thanks 🙏 Who can merge and tag a release?
There was a problem hiding this comment.
Anyone in the Terraformers team, or me next month once I'm (slightly) freed from my current deadlines.
@thats4shaw @mfendeksilverstripe if anyone has someone available to test/review/etc.
There was a problem hiding this comment.
@satrun77 @chrispenny I've got some time blocked out next week to get this sorted out.
Apologies for the delay here, the team was been slammed.
|
Checking if we could get this merged and released @thats4shaw or @mfendeksilverstripe |
thats4shaw
left a comment
thats4shaw
left a comment
There was a problem hiding this comment.
Appreciate the nudge @obj63mc.
Everything seems to be working nicely from my testing. Nice work @TheSceneman and @satrun77!
5 participants
This PR replaces deprecated Sillverstripe classes with their new namespaces.
It also updates the PHPUnit to version 11 to be in-step with the CMS. This includes a number of changes such as data providers needing to be static and annotations uses rather than @metadata.
Tests passing locally on a SS6 install. Cursory functional testing is good (tested key generation on some pages, and global cares on SiteConfig)