Skip to content

ENH Make it clear deprecations are removed in future major #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emteknetnz merged 1 commit into from
Apr 30, 2025
Merged

ENH Make it clear deprecations are removed in future major #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Shortcodes/FileLink.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class FileLink extends DataObject
*
* @config
* @var bool
* @deprecated 2.4.0 Will be removed without equivalent functionality to replace it
* @deprecated 2.4.0 Will be removed without equivalent functionality to replace it in a future major release
*/
private static $hide_in_campaigns = true;
}
2 changes: 1 addition & 1 deletion src/Shortcodes/ImageShortcodeProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ public static function handle_shortcode($args, $content, $parser, $shortcode, $e
*/
public static function createImageTag(array $attributes) : string
{
Deprecation::notice('2.3.0', 'Will be removed without equivalent functionality to replace it.');
Deprecation::notice('2.3.0', 'Will be removed without equivalent functionality to replace it in a future major release.');
$preparedAttributes = '';
foreach ($attributes as $attributeKey => $attributeValue) {
if (strlen($attributeValue ?? '') > 0 || $attributeKey === 'alt') {
Expand Down