Merged
Conversation
GuySartorelli
commented
Jun 26, 2025
| use SilverStripe\Assets\Storage\AssetStore; | ||
| use SilverStripe\Core\Config\Config; | ||
| use SilverStripe\Dev\SapphireTest; | ||
| use SilverStripe\ORM\DataObject; |
GuySartorelli
force-pushed
the
pulls/3/update-caching
branch
from
7bed837 to
115ecfa
Compare
Replaces deprecated `DataObject::get_one()` and `DataObject::get_by_id()` in favour of the new DataList query caching. Tests have been updated to remove caching where it's not relevant to the test.
GuySartorelli
force-pushed
the
pulls/3/update-caching
branch
from
115ecfa to
e8bd12e
Compare
emteknetnz
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces deprecated
DataObject::get_one()andDataObject::get_by_id()in favour of the new DataList query caching.Tests have been updated to remove caching where it's not relevant to the test.
Important
Relies on silverstripe/silverstripe-framework#11768
DO NOT MERGE until that PR has been merged in
Issue
DataListsilverstripe-framework#11767