Skip to content

Make GridFieldComponents work with arbitrary ViewableData where practical (gridfieldextensions edition) #376

Description

@ChloeSartorelli

silverstripe/silverstripe-framework#10771 made it easier to use the core gridfield components with arbitrary data.

A similar review should be done with components in this module, so that it's easier to use them with non-DataObject data and so that it's clearer when that's just not an option.

Acceptance Criteria

  • Where practical, all GridFieldComponent classes work with arbitrary ViewableData
  • If some methods need to be implemented for a component to work, a clear exception is thrown indicating what changes the developer needs to make. See Make GridField components work with ViewableData where possible silverstripe-framework#11049 for examples
  • Tests are put in place to avoid regressions
  • For any component where it is not practical to use it with ViewableData (if any), this is clearly documented in a way that developers can identify from within their IDE.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions