Conversation
chrispenny
force-pushed
the
feature/synonym-management
branch
2 times, most recently
from
e27b57d to
77c2efd
Compare
blueo
requested changes
May 15, 2025
Contributor
blueo
left a comment
blueo
left a comment
There was a problem hiding this comment.
I'm just a bit confused around the PUT comment but otherwise this is looking good
blueo
approved these changes
May 18, 2025
chrispenny
force-pushed
the
feature/synonym-management
branch
from
4d623fe to
533c58a
Compare
chrispenny
force-pushed
the
feature/synonym-management
branch
from
533c58a to
06c0051
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by
Release of synonyms support in Silverstripe Search.
Dependencies
Once those two are merged, we'll need to update our minimum requirements here