Add support for multiple font styles#212
Conversation
a873aae to
1d8c5e4
Compare
9d85bcd to
a32ed69
Compare
a32ed69 to
5827c9b
Compare
|
This seems like a breaking change to me. Can we prepare it for v15? |
Sure. Let's convert it to draft. |
5827c9b to
9291e74
Compare
9291e74 to
b1f72f2
Compare
|
@mondeja Resolved conflicts and ready for review. |
|
Would you mind to resolve conflicts again? |
Good point. Do you have a good suggestion for the new style name? What about |
If it provides the same functionality than |
b1f72f2 to
1f82827
Compare
|
Thanks for your thoughts. I think I've kept the old icon style as Regular. And the new icon style is Fit. It's ready for review now. |
There was a problem hiding this comment.
I'm probably not expressing myself correctly. What I was saying earlier is that I think that the generated directory structure should be like this:
font
├── Fit
│ ├── SimpleIcons-Fit.eot
│ ├── SimpleIcons-Fit.otf
│ ├── SimpleIcons-Fit.svg
│ ├── SimpleIcons-Fit.ttf
│ ├── SimpleIcons-Fit.woff
│ └── SimpleIcons-Fit.woff2
├── simple-icons.css
├── SimpleIcons.eot
├── SimpleIcons.json
├── simple-icons.min.css
├── SimpleIcons.min.json
├── SimpleIcons.otf
├── SimpleIcons.svg
├── SimpleIcons.ttf
├── SimpleIcons.woff
└── SimpleIcons.woff2
Instead of the one currently being generated, which is this:
font
├── eot
│ ├── SimpleIcons-Fit.eot
│ └── SimpleIcons-Regular.eot
├── otf
│ ├── SimpleIcons-Fit.otf
│ └── SimpleIcons-Regular.otf
├── simple-icons.css
├── SimpleIcons.json
├── simple-icons.min.css
├── SimpleIcons.min.json
├── svg
│ ├── SimpleIcons-Fit.svg
│ └── SimpleIcons-Regular.svg
├── ttf
│ ├── SimpleIcons-Fit.ttf
│ └── SimpleIcons-Regular.ttf
├── woff
│ ├── SimpleIcons-Fit.woff
│ └── SimpleIcons-Regular.woff
└── woff2
├── SimpleIcons-Fit.woff2
└── SimpleIcons-Regular.woff2
For several reasons:
- Avoid the breaking change for consumers of needing to change the file used. This is a breaking change for most of them that does not offer benefits.
- Less directories.
- Less weird names in fonts.
|
How about this? I've moved all font files to the same directory. I also changed the data JSON file name to |
1f82827 to
600bfa9
Compare
mondeja
left a comment
There was a problem hiding this comment.
Much better. Thank you, this is great!
Related to #222
Resolves #211
Get a preview build
Download it from: simple-icons-font-multi-styles.zip
Changes
SimpleIcons-Squared.[ext]font filefont-stylein the font SVG templateWeb browser preview
Typeface preview
File tree