Improve Skychat on UI, Groups and Channel feature - #3670
Merged
mrpalide merged 5 commits intoAug 3, 2026
Merged
Conversation
…els, and a one-pane phone layout
…only topology, chunked backfill, request-only files, and an opt-in discovery catalog
- **Linux / Darwin / Windows:** `RegisterApp` is intentionally idempotent after visor resume support was added, but `TestRegistry` still expected duplicate registration to panic. - Synchronized the registry and aligned it byte-for-byte with the target branch implementation in `pkg/app/launcher/registry.go`. - Updated the stale test to verify replacement semantics in `pkg/app/launcher/launcher_test.go`. - **E2E:** restarting `visor-b` briefly raced DMSG reconnection. The first address-resolver `/health` request failed, permanently disabling SUDPH for that visor. - Added retries for transient transport errors within the existing 10-second timeout in `pkg/transport/network/addrresolver/client.go`. - Added a regression test in `pkg/transport/network/addrresolver/client_extra_test.go`. Passed: - `go test -race -count=1 ./pkg/app/launcher` - `go test -count=1 ./pkg/transport/network/addrresolver` - `go test -count=1 ./pkg/transport/network/...` - `git diff --check` - Editor diagnostics for all changed files The full Docker E2E suite was not rerun locally. The four attached log files remain untracked and untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check? YesFixes #_
Changes:
How to test this PR:
then open
http://localhost:8001andhttp://localhost:8002on different browser and check new changes.