Skip to content

build(webhook): package for nodenext es6 with minimum node20 test - #2393

Closed
zimeg wants to merge 9 commits into
mainfrom
webhook-8.0.0-development
Closed

build(webhook): package for nodenext es6 with minimum node20 test#2393
zimeg wants to merge 9 commits into
mainfrom
webhook-8.0.0-development

Conversation

@zimeg

@zimeg zimeg commented Oct 4, 2025

Copy link
Copy Markdown
Member

Summary

WIP for #2359!

Requirements

@zimeg zimeg added this to the webhook@8.0.0 milestone Oct 4, 2025
@zimeg zimeg self-assigned this Oct 4, 2025
@zimeg zimeg added semver:major tests M-T: Testing work only pkg:webhook applies to `@slack/webhook` labels Oct 4, 2025
@codecov

codecov Bot commented Oct 4, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.14815% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.96%. Comparing base (ff03f78) to head (56a6183).
⚠️ Report is 87 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2393      +/-   ##
==========================================
- Coverage   93.01%   92.96%   -0.06%     
==========================================
  Files          40       42       +2     
  Lines       11112    11169      +57     
  Branches      713      691      -22     
==========================================
+ Hits        10336    10383      +47     
- Misses        764      774      +10     
  Partials       12       12              
Flag Coverage Δ
cli-hooks 95.23% <ø> (ø)
cli-test 94.80% <ø> (ø)
oauth 77.39% <ø> (ø)
socket-mode 61.87% <ø> (ø)
web-api 98.07% <ø> (ø)
webhook 93.93% <98.14%> (-2.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@WilliamBergamin

Copy link
Copy Markdown
Contributor

i think we can close this 🙏

@zimeg

zimeg commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

@WilliamBergamin Thanks for poking this! I agree! The latest webhook@v8 captures most of these improvements and I'm optimistic we'll land more in time: ESM in particular interests me!

@zimeg zimeg closed this Jul 14, 2026
@zimeg
zimeg deleted the webhook-8.0.0-development branch July 14, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:webhook applies to `@slack/webhook` semver:major tests M-T: Testing work only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants