fix(web-api): widen Slack Lists message field type#2599
Open
AjTheSpidey wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: f63d812 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for the contribution! Before we can merge this, we need @AjTheSpidey to sign the Salesforce Inc. Contributor License Agreement. |
Contributor
|
Hi, @AjTheSpidey! Thanks for your contribution! Could you please sign the CLA? |
Author
Unfortunately my parents have not responded to me if they will allow me to sign, I am only 14 and i need my parents permission to sign it 😅. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SlackListsItemFieldMessage.messageto accept request URL arrays, a single returned message object, or returned message object arraystsdcoverage for the preserved request shape and the response object shapes@slack/web-apiFixes #2598
Validation
npm run build --workspace=@slack/loggernpm run build --workspace=@slack/typesnpm run build --workspace=@slack/web-apinpm run test:types --workspace=@slack/web-apinpx @biomejs/biome check packages/web-api/src/types/request/slackLists.ts packages/web-api/test/types/methods/slacklists.test-d.ts .changeset/slack-lists-message-field.mdpackages/web-api:node --import tsx --test src/*.test.ts(154 tests passed)