feat(deployment): enable chosing party on operations#673
Merged
Conversation
rodrigombsoares
force-pushed
the
multi-party-operations
branch
from
June 15, 2026 13:24
eb0281c to
783d1ba
Compare
rodrigombsoares
marked this pull request as ready for review
June 15, 2026 13:29
friedemannf
approved these changes
Jun 15, 2026
| } | ||
| linkInstrumentId := splice_api_token_holding_v1.InstrumentId{ | ||
| Admin: types.PARTY(partyCCIP), | ||
| Admin: types.PARTY(partySender), |
Member
There was a problem hiding this comment.
Could you rename these participant/party variables and introduce a third participant/party that is the actual sender?
As-is I think this is blurring the lines between poolOwner/sender, as the poolOwner will also be the party sending the message
Contributor
Author
There was a problem hiding this comment.
It is indeed in this case. The client is the one sending and also owning the pool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for
deploymentandexerciseoperations to target a specific Canton participant instead of always usingParticipant[0]. TAR registration now separates CCIP owner, TokenConfig admin, and pool contract owner. Integration tests for tokens use dual EDS (CCIP on P0, token pool on P1) with split ownership.Features
Participant-aware deployment
ParticipantIndexon deploy/exercise;ParticipantAthelperMCMS routing
ProposalDrivenForCaller— proposal mode when submitter cannot ActAs caller (ReadAs ≠ MCMS)RegisterTokenPooluses separate MCMS flags for propose (ccip) vs accept/set-pool (admin)TAR registration (3-party model)
CcipParty— registry owner;ProposeAdministratorcallerPoolAdminParty— TokenConfig admin;AcceptAdminRole+SetPoolcaller (e2e: ccipOwner)PoolOwnerParty— pool contract owner; stored inPoolRegistrationonlyRegisterTokenPoolchangeset; deploy changesets passPoolAdminParty: CcipOwnerEDS
omitempty,required_if=Enabled)Integration tests (BnM + LnR)
RegisterTokenPoolwithPoolAdmin: partyCCIP,PoolOwner: partySenderpoolOwner == senderTesting