Conversation
Contributor
✅ API Diff Results -
|
| if !b.scope.IsTenantRequired() { | ||
| kvs := contexts.CREValue(ctx).LoggerKVs() | ||
| b.lggr.Warnw("Unable to get scoped bound limit due to missing tenant: failing open", append([]any{"scope", b.scope}, kvs...)...) | ||
| b.lggr.Errorw("Unable to get scoped bound limit due to missing tenant: failing open", append([]any{"scope", b.scope}, kvs...)...) |
Contributor
There was a problem hiding this comment.
As discussed offline, will this just spam the logs if the limit in question was designed to only work at a global scope?
Contributor
Author
There was a problem hiding this comment.
No, global limits won't enter this block b/c of the check at the top.
jmank88
force-pushed
the
org-err
branch
2 times, most recently
from
July 21, 2026 14:56
1677104 to
c5d3052
Compare
jmank88
commented
Jul 21, 2026
| if ok && tme.Scope.IsTenantRequired() { | ||
| return "", fmt.Errorf("failed to get raw keys: %w", err) | ||
| } else { | ||
| t.lggr.Errorf("Settings lookup for "+key+" limited by missing tenant at scope "+tme.Scope.String(), "key", key, "err", err) |
Contributor
Author
There was a problem hiding this comment.
@prashantkumar1982 These could be noisier than the other kind, since they are per lookup, but there are still not false positives.
pavel-raykov
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards https://smartcontract-it.atlassian.net/browse/CRE-1707
Raise level, and add logs for when just doing a setting lookup, which was a silent failure before via omission of the key.
I also cleaned up some production loggers being used from tests (which just spams std out in real time, even when a test is passing)