Add support for rustls-platform-verifier#528
Add support for rustls-platform-verifier#528FrankenApps wants to merge 1 commit intosnapview:masterfrom
Conversation
22d57a0 to
b94dfb0
Compare
|
@daniel-abramov Is this something you would consider? |
|
CI failure seems unrelated: |
There was a problem hiding this comment.
Thanks for the PR!
@daniel-abramov Is this something you would consider?
Yes. I think it's the right direction in the long term.
The only concern I have with these particular changes is that cargo features are meant to be additive, and I think it could be seen as an unexpected behavior if one feature "silently overwrites" the other.
CI failure seems unrelated:
Oh right. I've just updated the master to incorporate the fix.
b94dfb0 to
54020fb
Compare
I agree that this is somewhat unfortunate, albeit also expected behavior for these A notable exception is the latest version of Therefore while I think that a If you see it as a blocker for merging and nobody else can give me guidance for how to improve the PR in that regard, feel free to close it. |
54020fb to
3f9e5cf
Compare
|
@daniel-abramov Rebased on top of master in order to fix the unrelated clippy issue in CI. |
Adds support for
rustls-platform-verifieras mentioned in #522.However contrary to the plan outlined in that issue I left the
rustls-native-certsfeature untouched for now.I also did not implement support for additional root certificates (
new_with_extra_roots), because it works differently than the current approach based onRootCertStore.