Update sha1 to version 0.11.0 and rand to version 0.10.0#529
Update sha1 to version 0.11.0 and rand to version 0.10.0#529LilithSilver wants to merge 1 commit intosnapview:masterfrom
Conversation
|
I think I'd rather wait for a stable release should this become necessary. Using the release candidate version is not encouraged, especially in [somewhat popular] libraries. |
I generally agree; but docs.rs will fail to build for any users (or tungstenite itself) until those packages are updated... Good news, |
Hm... |
Apologies, I missed an important thing. The downstream packages that fail rely on the following rustdoc/rustc args, as described here. This can be simulated by putting this inside of Tungstenite's Cargo.toml in the proper location, then run the docs-rs build. (with Since Tungstenite doesn't use those cfg features, the issue won't present itself on this package's build, only packages that use Tungstenite and rely on those features to build their docs. |
|
Yes, the errors were unrelated and fixed in I confirm that I can reproduce the error when using the flags. This is an interesting issue; I might need to research how other packages have dealt with it and what's the best way to address it (judging from the linked/mentioned issues the problem must have affected multiple popular crates), . I'm (typically) a bit uncomfortable being dependent on |
author LilithSilver <84940819+LilithSilver@users.noreply.github.com> 1767816227 -0800 committer Lilith Silver <84940819+LilithSilver@users.noreply.github.com> 1775589812 -0700 Update sha1 dependency to version 0.11.0-rc.3 Update rand dependency to version 0.10.0-rc.6 Update rand dependency version to 0.10.0 Update sha1 dependency version to 0.11.0 Update rand dependency to version 0.10.0-rc.6 Update rand dependency version to 0.10.0 Update sha1 dependency version to 0.11.0
|
Good news, looks like sha1 0.11 finally released, so problem solved! I rebased, squashed, and pushed. |
|
Yep, thanks for the update. I saw the update in |

The main release version of
sha1has an issue where the deeply-nested dependencygeneric-arraystill includesdoc_auto_cfg, which is deprecated in rust nightly. Recent docs.rs builds fail when the old version is included. This bumps the version to stop the issue.randhas a similar issue.I've managed to request updates from all other upstream nested dependencies; those aren't pre-release versions, so Cargo should be able to update them OK.