Skip to content

chore(language-server): integrate LS#7035

Open
team-ide-user wants to merge 1 commit into
mainfrom
chore/automatic-upgrade-of-ls
Open

chore(language-server): integrate LS#7035
team-ide-user wants to merge 1 commit into
mainfrom
chore/automatic-upgrade-of-ls

Conversation

@team-ide-user

Copy link
Copy Markdown
Contributor

Changes since last integration of Language Server

commit 920eb24fdb6677d8767aa86ca6153242ca80f535
Author: Ben Durrans <Benjamin.Durrans@snyk.io>
Date:   Fri Jul 24 16:13:54 2026 +0100

    chore: fallback settings clear credentials button styling and label (#1386)
    
    * fix(settings): align fallback clear credentials control
    
    Update fallback settings authentication control to match full settings secondary button styling.
    
    - Rename button text to Clear credentials
    - Remove initial helper copy above the button
    - Apply secondary button colors and hover tokens used by full settings page
    - Keep post-action status feedback after snyk.logout completes
    - Add/adjust fallback JS tests for new label and empty pre-action status
    
    Co-authored-by: Ben Durrans <Benjamin.Durrans@snyk.io>
    
    * fix(settings): simplify fallback sign-out status copy
    
    Update fallback post-logout status text to the concise message requested: 'Signed out.'.
    
    Also align the related fallback JS assertion/test name with the new copy.
    
    Co-authored-by: Ben Durrans <Benjamin.Durrans@snyk.io>
    
    * fix(settings): move aria-live to always-visible parent for logout status
    
    aria-live on the display:none <p> at load isn't reliably announced by
    screen readers; the wrapping .form-group stays in the a11y tree, so
    the live region works when the status text is later revealed.
    
    ---------
    
    Co-authored-by: Cursor Agent <cursoragent@cursor.com>
    Co-authored-by: Andrew Robinson Hodges <andrew.robinsonhodges@snyk.io>

M	js-tests/settings-fallback.test.mjs
M	shared_ide_resources/ui/html/settings-fallback.html

@team-ide-user
team-ide-user requested a review from a team as a code owner July 24, 2026 15:19
@team-ide-user
team-ide-user enabled auto-merge July 24, 2026 15:20
@snyk-io

snyk-io Bot commented Jul 24, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown
Contributor
Warnings
⚠️

"chore: automatic integration of language server 920eb24fdb6677d8767aa86ca6153242ca80f535" is too long. Keep the first line of your commit message under 72 characters.

Generated by 🚫 dangerJS against 9ea59be

@snyk-pr-review-bot

Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected
📚 Repository Context Analyzed

This review considered 4 relevant code sections from 4 files (average relevance: 0.98)

🤖 Repository instructions applied (from AGENTS.md)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant