fix unsoundness in Exception code FFI conversion#27
Merged
Conversation
The C stub previously wrote a u32 directly into a #[repr(u32)] enum field, which is undefined behavior when the raised exception code is not covered by ExceptionCode's 24 variants. Store the raw u32 in Exception and convert via a safe match in From<u32>, mapping unknown codes to ExceptionCode::Invalid. Expose Exception::raw_code() so callers can still inspect the raw value when the kernel produces a code outside the enum.
Owner
|
lgtm, thank you! 🚀 |
Contributor
Author
|
Great. Thanks! Do intend to bump the version anytime soon? |
Owner
|
Yes, I'll release the update on Cargo as soon as I have my hands on a Windows machine :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C stub previously wrote a u32 directly into a #[repr(u32)] enum field, which is undefined behavior when the raised exception code is not covered by ExceptionCode's 24 variants.
Store the raw u32 in Exception and convert via a safe match in From, mapping unknown codes to ExceptionCode::Invalid. Expose Exception::raw_code() so callers can still inspect the raw value when the kernel produces a code outside the enum.