fix: 올바른 홈 디렉토리 경로로 수정#873
Conversation
cicd 재배포를 위한 코드 일부 추가
서버통합 부하테스트용 진행
redis 비활성화 및 jar 파일 app.jar 인식할 수 있도록 변경!
Hotfix/main disable redis
hotfix: revert previous develop merge revert
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
개요프로덕션 배포 SSH 명령어의 작업 디렉터리를 변경사항빌드 아티팩트 구성
배포 스크립트 수정
예상 코드 리뷰 난이도🎯 3 (중간) | ⏱️ ~25분 관련 PR
추천 라벨
추천 리뷰어
축하 시
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@main/src/main/java/org/sopt/makers/crew/main/external/redis/RedisConfig.java`:
- Around line 6-7: CaffeineConfig is disabled for the "lambda-dev" profile so
all `@Cacheable/`@CachePut/@CacheEvict become no-ops; add a small profile-specific
cache configuration that enables Spring caching and provides an in-memory
CacheManager for lambda-dev (e.g., create a LambdaDevCacheConfig or update
RedisConfig to annotate `@Configuration` and `@Profile`("lambda-dev") and add
`@EnableCaching` plus a CacheManager bean that returns a ConcurrentMapCacheManager
(or similar simple fallback) so MeetingReader, CoLeaderReader, UserReader,
MeetingV2ServiceImpl, FlashV2ServiceImpl, AuthV2UserCacheCommandServiceImpl keep
functional caching when Redis is disabled.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 58f41a53-935f-431b-a656-5667cce4959a
📒 Files selected for processing (4)
.github/workflows/prod-ci-cd.ymlmain/Dockerfilemain/build.gradlemain/src/main/java/org/sopt/makers/crew/main/external/redis/RedisConfig.java
| //@EnableCaching | ||
| //@Profile("lambda-dev") |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "[1] Active cache-related annotations"
rg -nP '^\s*@EnableCaching|^\s*@Profile\("!?lambda-dev"\)|^\s*@Cacheable|^\s*@CachePut|^\s*@CacheEvict' main/src/main/java
echo
echo "[2] RedisConfig"
sed -n '1,120p' main/src/main/java/org/sopt/makers/crew/main/external/redis/RedisConfig.java
echo
echo "[3] CaffeineConfig"
sed -n '1,80p' main/src/main/java/org/sopt/makers/crew/main/external/caffeine/CaffeineConfig.javaRepository: sopt-makers/sopt-crew-backend
Length of output: 3393
lambda-dev 프로필에서 캐싱이 비활성화됩니다.
CaffeineConfig에서 @EnableCaching이 @Profile("!lambda-dev")로 설정되어 있어서, lambda-dev 프로필에서는 어떤 캐시 설정도 활성화되지 않습니다. 그 결과 MeetingReader, CoLeaderReader, UserReader, MeetingV2ServiceImpl, FlashV2ServiceImpl, AuthV2UserCacheCommandServiceImpl의 @Cacheable/@CachePut/@CacheEvict 모든 어노테이션이 no-op이 됩니다. 의도가 "Redis 비활성화"라면, 캐싱 자체는 유지되도록 lambda-dev 전용 fallback CacheManager를 제공하는 편이 안전합니다.
예시 수정안
+import org.springframework.cache.CacheManager;
+import org.springframework.cache.annotation.EnableCaching;
+import org.springframework.cache.concurrent.ConcurrentMapCacheManager;
+import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
+import org.springframework.context.annotation.Profile;
`@Configuration`
+@EnableCaching
+@Profile("lambda-dev")
public class RedisConfig {
+ `@Bean`
+ public CacheManager cacheManager() {
+ return new ConcurrentMapCacheManager(
+ "meetingCache",
+ "coLeadersCache",
+ "meetingLeaderCache",
+ "orgIdCache"
+ );
+ }
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| //@EnableCaching | |
| //@Profile("lambda-dev") | |
| import org.springframework.cache.CacheManager; | |
| import org.springframework.cache.annotation.EnableCaching; | |
| import org.springframework.cache.concurrent.ConcurrentMapCacheManager; | |
| import org.springframework.context.annotation.Bean; | |
| import org.springframework.context.annotation.Configuration; | |
| import org.springframework.context.annotation.Profile; | |
| `@Configuration` | |
| `@EnableCaching` | |
| `@Profile`("lambda-dev") | |
| public class RedisConfig { | |
| `@Bean` | |
| public CacheManager cacheManager() { | |
| return new ConcurrentMapCacheManager( | |
| "meetingCache", | |
| "coLeadersCache", | |
| "meetingLeaderCache", | |
| "orgIdCache" | |
| ); | |
| } | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@main/src/main/java/org/sopt/makers/crew/main/external/redis/RedisConfig.java`
around lines 6 - 7, CaffeineConfig is disabled for the "lambda-dev" profile so
all `@Cacheable/`@CachePut/@CacheEvict become no-ops; add a small profile-specific
cache configuration that enables Spring caching and provides an in-memory
CacheManager for lambda-dev (e.g., create a LambdaDevCacheConfig or update
RedisConfig to annotate `@Configuration` and `@Profile`("lambda-dev") and add
`@EnableCaching` plus a CacheManager bean that returns a ConcurrentMapCacheManager
(or similar simple fallback) so MeetingReader, CoLeaderReader, UserReader,
MeetingV2ServiceImpl, FlashV2ServiceImpl, AuthV2UserCacheCommandServiceImpl keep
functional caching when Redis is disabled.
3 participants
👩💻 Contents
deploy.sh가 있는 올바른 경로로 수정하였습니다.
✅ 점검사항