PVC now properly gets disabled when persistence.enabled is false and secret can be disabled#7
Open
Sleuth56 wants to merge 4 commits intosoubenz:mainfrom
Open
PVC now properly gets disabled when persistence.enabled is false and secret can be disabled#7Sleuth56 wants to merge 4 commits intosoubenz:mainfrom
Sleuth56 wants to merge 4 commits intosoubenz:mainfrom
Conversation
Sleuth56
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this project, it's nice that most of the work was already done 😄. Fixed a bug where the PVC was still being generated when persistence.enabled was false. And made the secret optional so a user could define their own. Helpful when using argocd for deployments.