altcoin (blackcoin): upgrade to segwit, correct mainnet fees, add BLK tests - #391
Open
BlackcoinDev wants to merge 2 commits into
Open
altcoin (blackcoin): upgrade to segwit, correct mainnet fees, add BLK tests#391BlackcoinDev wants to merge 2 commits into
BlackcoinDev wants to merge 2 commits into
Conversation
- SegWit has been activated on mainnet since block 5805000. - Changed DeserializerBlackcoin to DeserializerBlackcoinSegWit. - Add correct minfee value for mainnet. - add block and transaction tests. - Already running in production.
Electrum-BLK v4.8.0 uses Electrum Protocol 1.6 and needs incrementalrelayfee value. Blackcoin has no RBF features, and 'getmempoolinfo' is missing the field. Without modifying the main code, it is better to create a specific BlackcoinDaemon class. and add Blackcoin specifics there. Also for future changes
|
Please let us know if we are missing something here, so we can change if needed. Thank you, and have a nice week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Electrum-BLK v4.8.0 uses Electrum Protocol 1.6 and needs incrementalrelayfee value.
Blackcoin has no RBF features, and 'getmempoolinfo' is missing the field. Without modifying the main code, it is better to create a specific BlackcoinDaemon class. and add Blackcoin specifics there. Also for future changes