Skip to content

Replace isAssignableFrom() with isInstance() where feasible#36899

Merged
sbrannen merged 1 commit into
spring-projects:mainfrom
quaff:patch-137
Jun 15, 2026
Merged

Replace isAssignableFrom() with isInstance() where feasible#36899
sbrannen merged 1 commit into
spring-projects:mainfrom
quaff:patch-137

Conversation

@quaff

@quaff quaff commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 11, 2026
@sbrannen sbrannen added the type: task A general task label Jun 11, 2026
@sbrannen

This comment was marked as outdated.

Sign in to view
@sbrannen sbrannen self-assigned this Jun 11, 2026
@sbrannen sbrannen added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 11, 2026
@sbrannen sbrannen added this to the 7.1.0-M1 milestone Jun 11, 2026
@quaff

quaff commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Out of curiosity, how did you come across all of these?

Did you use a special IDE check, AI agent support, ...?

Replace \.isAssignableFrom\((.+)\.getClass\(\)\) with .isInstance($1).

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jun 12, 2026
sbrannen

This comment was marked as outdated.

Sign in to view

@sbrannen sbrannen added status: waiting-for-feedback We need additional information before we can continue and removed status: feedback-provided Feedback has been provided labels Jun 12, 2026
@sbrannen sbrannen changed the title Replace isAssignableFrom with isInstance where feasible Replace isAssignableFrom() with isInstance() where feasible Jun 12, 2026
@quaff

This comment was marked as outdated.

Sign in to view
@quaff quaff requested a review from sbrannen June 12, 2026 09:03
@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jun 12, 2026
@sbrannen sbrannen added type: enhancement A general enhancement and removed status: feedback-provided Feedback has been provided type: task A general task labels Jun 12, 2026
sbrannen

This comment was marked as outdated.

Sign in to view

@sbrannen sbrannen added the status: waiting-for-feedback We need additional information before we can continue label Jun 12, 2026
@quaff
Replace isAssignableFrom() with isInstance() where feasible
236a165 
Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
sbrannen
sbrannen approved these changes Jun 15, 2026
View reviewed changes

@sbrannen sbrannen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. 👍

Thanks

@sbrannen sbrannen removed the status: waiting-for-feedback We need additional information before we can continue label Jun 15, 2026
@sbrannen sbrannen merged commit cdc3c52 into spring-projects:main Jun 15, 2026
2 checks passed
@sbrannen

sbrannen commented Jun 15, 2026

Copy link
Copy Markdown
Member

This has been merged into main.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbrannen sbrannen sbrannen approved these changes

Assignees

@sbrannen sbrannen

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

7.1.0-M1

Development

Successfully merging this pull request may close these issues.

3 participants

@quaff @sbrannen @spring-projects-issues