Skip to content

PR: Fix running batch files on paths with spaces (External Terminal) - #26193

Merged
ccordoba12 merged 1 commit into
spyder-ide:masterfrom
athompson673:patch-1
Jul 21, 2026
Merged

PR: Fix running batch files on paths with spaces (External Terminal)#26193
ccordoba12 merged 1 commit into
spyder-ide:masterfrom
athompson673:patch-1

Conversation

@athompson673

Copy link
Copy Markdown
Contributor

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

When running .bat files in the windows command prompt from spyder, file paths with spaces are not properly quoted. Git Blame indicated the removal of the closing quote was originally to make test suite pass, however after many struggles getting testing working locally, I cannot find an instance where this change affects spyder/app/tests/test_mainwindow.py::test_shell_execution.

Issue(s) Resolved

Fixes #26162

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: athompson673

@ccordoba12 ccordoba12 added this to the v6.1.6 milestone Jul 21, 2026
@ccordoba12 ccordoba12 changed the title PR: Restore closing quote for cmd.exe args PR: Fix running batch files on paths with spaces () Jul 21, 2026
@ccordoba12 ccordoba12 changed the title PR: Fix running batch files on paths with spaces () PR: Fix running batch files on paths with spaces (External Terminal) Jul 21, 2026

@ccordoba12 ccordoba12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding the fix to this problem @athompson673!

@ccordoba12
ccordoba12 merged commit 7bbffbc into spyder-ide:master Jul 21, 2026
31 of 32 checks passed
@ccordoba12

Copy link
Copy Markdown
Member

@meeseeksdev please backport to 6.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running batch script on Windows fails with space in file path

2 participants