Feat/dns zone observability extension#1540
Open
SerseusWasTaken wants to merge 3 commits into
Open
Conversation
SerseusWasTaken
force-pushed
the
feat/dns-zone-observability-extension
branch
5 times, most recently
from
f3b6422 to
fc58f24
Compare
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
feat(dns): implement observability extension
SerseusWasTaken
force-pushed
the
feat/dns-zone-observability-extension
branch
from
fc58f24 to
1eb0838
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
marceljk
reviewed
Jul 13, 2026
|
|
||
| // getExtensionsPayload reads the extensions from the model and maps it to [dns.ZoneExtensions]. | ||
| // Returns nil if the model does not provide any extensions. | ||
| func getExtensionsPayload(ctx context.Context, model *Model) (*dns.ZoneExtensions, error) { |
Contributor
There was a problem hiding this comment.
nitpick, I would rename it to stay consistent to other payload functions
Suggested change
| func getExtensionsPayload(ctx context.Context, model *Model) (*dns.ZoneExtensions, error) { | |
| func toExtensionsPayload(ctx context.Context, model *Model) (*dns.ZoneExtensions, error) { |
Comment on lines
+784
to
+787
| observabilityExtension := dns.NewZoneObservabilityExtension(obs.InstanceId.ValueString()) | ||
| return &dns.ZoneExtensions{ | ||
| ObservabilityExtension: observabilityExtension, | ||
| }, nil |
Contributor
There was a problem hiding this comment.
personal preference, I like this style more, because you can read which attribute is set with which value and without jumping into the function and checking it there
Suggested change
| observabilityExtension := dns.NewZoneObservabilityExtension(obs.InstanceId.ValueString()) | |
| return &dns.ZoneExtensions{ | |
| ObservabilityExtension: observabilityExtension, | |
| }, nil | |
| return &dns.ZoneExtensions{ | |
| ObservabilityExtension: &dns.ZoneObservabilityExtension{ | |
| ObservabilityInstanceId: obs.InstanceId.ValueString(), | |
| }, | |
| }, nil |
| ex := extensions{} | ||
| diags := model.Extensions.As(ctx, &ex, basetypes.ObjectAsOptions{}) | ||
| if diags.HasError() { | ||
| return nil, fmt.Errorf("failed to map extensions to domain type: %v", diags.Errors()) |
Contributor
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("failed to map extensions to domain type: %v", diags.Errors()) | |
| return nil, fmt.Errorf("failed to map extensions to domain type: %w", core.DiagsToError(diags)) |
| obs := observability{} | ||
| diags = ex.Observability.As(ctx, &obs, basetypes.ObjectAsOptions{}) | ||
| if diags.HasError() { | ||
| return nil, fmt.Errorf("failed to map extensions to domain type: %v", diags.Errors()) |
Contributor
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("failed to map extensions to domain type: %v", diags.Errors()) | |
| return nil, fmt.Errorf("failed to map extensions to domain type: %w", core.DiagsToError(diags)) |
| variable "default_ttl" {} | ||
| variable "description" {} | ||
| variable "expire_time" {} | ||
| variable "ext_observability_instance_id" {} |
Contributor
There was a problem hiding this comment.
is this a testing leftover?
Comment on lines
+52
to
+53
| "ext_observability_instance_id": config.StringVariable("a8f823ad-3abb-47fb-b56a-e3a7e97f65d5"), | ||
| // "ext_observability_state": config.StringVariable("disabled"), |
Contributor
There was a problem hiding this comment.
same here, testing leftover?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to #STACKITTPR-319 and closes #941
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)